Get or set the file caching mode #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
reviewed
Apr 29, 2025
|
We need to restore the github workflows to see if JS/wasm backends function. If you don't want to do that, I'll do it later this week. |
Bodigrim
reviewed
Apr 29, 2025
System/Posix/Fcntl.hsc
Outdated
| -- Throws 'IOError' (\"unsupported operation\") if platform does not support | ||
| -- reading the cache mode. | ||
| -- | ||
| -- (use @#if HAVE_O_DIRECT@ CPP guard to detect availability). |
There was a problem hiding this comment.
Is this macro available to a user though?
There was a problem hiding this comment.
I'd prefer the documentation to say so explicitly, otherwise people will be left wondering who defines them.
There was a problem hiding this comment.
I've now added a hint to use #include "HsUnix.h" to bring the macros into scope
Bodigrim
reviewed
Apr 29, 2025
|
Can you rebase against master? |
Will do |
jorisdral
force-pushed
the
jdral/issue-322
branch
from
4b39741 to
b648df3
Compare
hasufell
reviewed
Apr 30, 2025
jorisdral
commented
Apr 30, 2025
jorisdral
force-pushed
the
jdral/issue-322
branch
from
8725f7c to
9d4c1eb
Compare
|
All CI jobs except OpenBSD seem to pass (seems like a problem with the job/runner, not the code?). I can squash the commits into one if the changes are okay to merge |
hasufell
approved these changes
Apr 30, 2025
Bodigrim
reviewed
May 1, 2025
Bodigrim
approved these changes
May 6, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #322